[webkit-reviews] review canceled: [Bug 74251] Remove support for the RVCT compiler. : [Attachment 118702] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has canceled Andreas Kling
<kling at webkit.org>'s request for review:
Bug 74251: Remove support for the RVCT compiler.
https://bugs.webkit.org/show_bug.cgi?id=74251

Attachment 118702: Patch
https://bugs.webkit.org/attachment.cgi?id=118702&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=118702&action=review


I am find with the Symbian defines, but the Linux RVCT ones probably need to
stay.
Let's wait until there are response on WebKit-dev.

e.g.:

> Source/JavaScriptCore/jit/ExecutableAllocator.cpp:-177
> -#if CPU(ARM_TRADITIONAL) && OS(LINUX) && COMPILER(RVCT)
> -
> -__asm void ExecutableAllocator::cacheFlush(void* code, size_t size)
> -{
> -    ARM
> -    push {r7}
> -    add r1, r1, r0
> -    mov r7, #0xf0000
> -    add r7, r7, #0x2
> -    mov r2, #0x0
> -    svc #0x0
> -    pop {r7}
> -    bx lr
> -}
> -
> -#endif
> -

I doubt this is related to Symbian's RVCT.

> Source/JavaScriptCore/jit/ExecutableAllocator.h:-186
> -#elif CPU(ARM_TRADITIONAL) && OS(LINUX) && COMPILER(RVCT)
> -    static __asm void cacheFlush(void* code, size_t size);

Ditto