[webkit-reviews] review denied: [Bug 74048] A function of vector multiply with SSE optimization is needed in VectorMath.cpp : [Attachment 118323] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied xingnan.wang at intel.com's
request for review:
Bug 74048: A function of vector multiply with SSE optimization is needed in
VectorMath.cpp
https://bugs.webkit.org/show_bug.cgi?id=74048

Attachment 118323: Patch
https://bugs.webkit.org/attachment.cgi?id=118323&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=118323&action=review


This change needs a ChangeLog.

> Source/WebCore/platform/audio/VectorMath.cpp:318
> +	   // Non-SSE handling for left frames which are less than 4.
> +	   n %= 4;
> +	   while (n) {
> +	       *destP = *source1P * *source2P;
> +	       source1P++;
> +	       source2P++;
> +	       destP++;
> +	       n--;
> +	   }
> +    } else { // If strides are not 1, rollback to normal algorithm.
> +#endif
> +    int n = framesToProcess;
> +    while (n--) {
> +	   *destP = *source1P * *source2P;
> +	   source1P += sourceStride1;
> +	   source2P += sourceStride2;
> +	   destP += destStride;
> +    }

You can unify those two path and avoid the else {} branch. Just declare "int n
= framesToProcess;" above the block.