[webkit-reviews] review granted: [Bug 73586] Upstream text codec and web string files of BlackBerry API : [Attachment 118629] Updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Dec 10 01:21:12 PST 2011

Nikolas Zimmermann <zimmermann at kde.org> has granted Jacky Jiang
<zkjiang008 at gmail.com>'s request for review:
Bug 73586: Upstream text codec and web string files of BlackBerry API

Attachment 118629: Updated patch

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=118629&action=review

Looks good, r=me! Please fix these before landing, or upload another patch that
I could cq+.

> Source/WebKit/blackberry/Api/WebKitTextCodec.cpp:23
> +#include "CString.h"


> Source/WebKit/blackberry/Api/WebKitTextCodec.cpp:53
> +    String lowercasedEncoding = String(encoding).lower();
> +    if (lowercasedEncoding.startsWith("iso-8859")

We might want to add a comment here, that this is slow and could easily be
optimized, by directly inspecting encoding[i].

> Source/WebKit/blackberry/Api/WebString.cpp:26
> +using WTF::String;

WTFString.h already declares that, this is unncessary here, no?

> Source/WebKit/blackberry/Api/WebString.cpp:109
> +    return WTF::equal(m_impl, utf8);

doesn't WTF already do "using WTF::equal" in their public headers?

> Source/WebKit/blackberry/Api/WebString.cpp:114
> +    return WTF::equalIgnoringCase(m_impl, utf8);


More information about the webkit-reviews mailing list