[webkit-reviews] review granted: [Bug 74229] background-image transitions trigger between equivalent images : [Attachment 118668] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Dec 9 17:16:02 PST 2011
Darin Adler <darin at apple.com> has granted Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 74229: background-image transitions trigger between equivalent images
https://bugs.webkit.org/show_bug.cgi?id=74229
Attachment 118668: patch
https://bugs.webkit.org/attachment.cgi?id=118668&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=118668&action=review
> Source/WebCore/page/animation/AnimationBase.cpp:385
> + if ((!a && !b) || a == b)
No need for the first half of this expression. Just a == b will do.
> Source/WebCore/page/animation/AnimationBase.cpp:698
> + if ((!a && !b) || a == b)
Ditto.
More information about the webkit-reviews
mailing list