[webkit-reviews] review denied: [Bug 74164] Add the FileSystem functions of iOS : [Attachment 118529] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has denied Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 74164: Add the FileSystem functions of iOS
https://bugs.webkit.org/show_bug.cgi?id=74164

Attachment 118529: Patch
https://bugs.webkit.org/attachment.cgi?id=118529&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=118529&action=review


r- to address a strategy for Source/WebKit code sharing and platform structure.


It may be easier to land the WebCore pieces first.

> Source/WebKit/mac/Misc/WebNSFileManagerExtras.h:39
>  @interface NSFileManager (WebNSFileManagerExtras)
> +#if !PLATFORM(IOS)
>  - (void)_webkit_setMetadataURL:(NSString *)URLString referrer:(NSString
*)referrer atPath:(NSString *)path;
>  - (NSString *)_webkit_startupVolumeName;
> +#endif // !PLATFORM(IOS)
> +
> +#if PLATFORM(IOS)
> +- (NSString *)_webkit_createTemporaryDirectoryWithTemplatePrefix:(NSString
*)prefix;
> +#endif // PLATFORM(IOS)

We need to come up with a better strategy for sharing this code rather than
mixing Mac-only, iOS-only and shared methods into a single header and
implementation file.

Also, adding PLATFORM(IOS) macros won't work for any public headers unless we
start post-processing the headers to strip out these macros, and it could
impact any Apple projects using private headers as SPI (since these macros
won't be defined when they build their projects).