[webkit-reviews] review granted: [Bug 74214] [chromium] Add worldId parameter to allowScriptExtension() : [Attachment 118640] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted James Kozianski
<koz at chromium.org>'s request for review:
Bug 74214: [chromium] Add worldId parameter to allowScriptExtension()
https://bugs.webkit.org/show_bug.cgi?id=74214

Attachment 118640: Patch
https://bugs.webkit.org/attachment.cgi?id=118640&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=118640&action=review


> Source/WebKit/chromium/public/WebPermissionClient.h:77
> +    virtual bool allowScriptExtension(WebFrame*, const WebString&
extensionName, int extensionGroup, int worldId) { return true; }

usually we make the default implementation of the new method call the old
method.
that helps us keep the system working while we transition chrome over to impl
the new method.