[webkit-reviews] review granted: [Bug 74191] YARR: Multi-character read optimization for 8bit strings : [Attachment 118636] Patch

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has granted Michael Saboff <msaboff at apple.com>'s
request for review:
Bug 74191: YARR: Multi-character read optimization for 8bit strings
https://bugs.webkit.org/show_bug.cgi?id=74191

Attachment 118636: Patch
https://bugs.webkit.org/attachment.cgi?id=118636&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=118636&action=review


> Source/JavaScriptCore/yarr/YarrJIT.cpp:728
> +		   {

brace should follow the :, and you've over indented the code :D

> Source/JavaScriptCore/yarr/YarrJIT.cpp:756
>	       }

Can't we do a 4 character compare on 64bit?