[webkit-reviews] review granted: [Bug 71244] CSS 2.1 failure: border-conflict-element-* : [Attachment 118609] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Robert Hogan <robert at webkit.org>'s
request for review:
Bug 71244: CSS 2.1 failure: border-conflict-element-*
https://bugs.webkit.org/show_bug.cgi?id=71244

Attachment 118609: Patch
https://bugs.webkit.org/attachment.cgi?id=118609&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=118609&action=review


> Source/WebCore/rendering/RenderTableCell.cpp:809
> +    ASSERT(!(paintInfo.phase == PaintPhaseCollapsedTableBorders));

Probably would read better with !=.

> Source/WebCore/rendering/RenderTableCell.cpp:896
> +    if ((*a).isSameIgnoringColor(*b))

Should use the -> operator here instead of (*a).

> Source/WebCore/rendering/RenderTableSection.cpp:998
> +    if ((!cell->hasSelfPaintingLayer() && !row->hasSelfPaintingLayer()))

There’s an extra set of parentheses here we should remove.