[webkit-reviews] review denied: [Bug 10900] Negative margin block doesn't properly clear a float enclosed by a previous sibling : [Attachment 107184] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 9 14:11:34 PST 2011


Dave Hyatt <hyatt at apple.com> has denied Robert Hogan <robert at webkit.org>'s
request for review:
Bug 10900: Negative margin block doesn't properly clear a float enclosed by a
previous sibling
https://bugs.webkit.org/show_bug.cgi?id=10900

Attachment 107184: Patch
https://bugs.webkit.org/attachment.cgi?id=107184&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
This isn't the right way to handle this. If/when things shift to cause new
floats to potentially overhang, we should just call addOverhangingFloats again.
We should not change the definition of what addOverhangingFloats does.


More information about the webkit-reviews mailing list