[webkit-reviews] review granted: [Bug 74162] Implement CSS resize property in CSSStyleApplyProperty. : [Attachment 118528] Patch

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has granted Luke Macpherson
<macpherson at chromium.org>'s request for review:
Bug 74162: Implement CSS resize property in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=74162

Attachment 118528: Patch
https://bugs.webkit.org/attachment.cgi?id=118528&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=118528&action=review


> Source/WebCore/css/CSSStyleApplyProperty.cpp:1160
> +	   if (!primitiveValue->getIdent())
> +	       return;
> +
> +	   EResize r = RESIZE_NONE;
> +	   switch (primitiveValue->getIdent()) {
> +	   case 0:
> +	       return;

This was not in the original code. It also looks like it is doing exactly the
check above so it should be removed.