[webkit-reviews] review granted: [Bug 73668] Upstream BlackBerry API backing store files : [Attachment 118601] Updated patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Jacky Jiang
<zkjiang008 at gmail.com>'s request for review:
Bug 73668: Upstream BlackBerry API backing store files
https://bugs.webkit.org/show_bug.cgi?id=73668

Attachment 118601: Updated patch
https://bugs.webkit.org/attachment.cgi?id=118601&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=118601&action=review


> Source/WebKit/blackberry/Api/BackingStore.cpp:1957
> +void BackingStorePrivate::actualVisibleSizeChanged(const Platform::IntSize&
size)

We should ultimately remove this method since it has an empty implementation.
We can do this in a follow up bug.

> Source/WebKit/blackberry/Api/BackingStore.cpp:2054
> +    static int tw = 0;

I would write lines 2054-2056 as:

static int tileWidth =
BlackBerry::Platform::Graphics::Screen::landscapeWidth();

> Source/WebKit/blackberry/Api/BackingStore.cpp:2062
> +    static int th = 0;

I would use a similar approach here.