[webkit-reviews] review granted: [Bug 74170] DFG's interpretation of rare case profiles should be frequency-based not count-based : [Attachment 118627] the patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 74170: DFG's interpretation of rare case profiles should be frequency-based
not count-based
https://bugs.webkit.org/show_bug.cgi?id=74170

Attachment 118627: the patch
https://bugs.webkit.org/attachment.cgi?id=118627&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=118627&action=review


r=me

> Source/JavaScriptCore/runtime/Heuristics.cpp:148
> +    SET(likelyToTakeSlowCaseMinimumCount, 100);

It seems like this 100 limit is still problematic in the first example you
gave.