[webkit-reviews] review denied: [Bug 70810] nameNodeListCache should be invalidated when name attribute changes/modified. : [Attachment 118617] Updated patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied  review:
Bug 70810: nameNodeListCache should be invalidated when name attribute
changes/modified.
https://bugs.webkit.org/show_bug.cgi?id=70810

Attachment 118617: Updated patch
https://bugs.webkit.org/attachment.cgi?id=118617&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=118617&action=review


> LayoutTests/fast/dom/getelementsbyname-invalidation-cache.html:35
> +    document.getElementById('testElement').setAttribute('name',
'changed-name');
> +    shouldBe("document.querySelector('" + tagName + "');
document.getElementsByName('fullname').length", "1");

Wait... what's the point of querySelector here? You should be doing
document.querySelector('" + tagName + "').setAttribute('name', 'changed-name')
here instead.