[webkit-reviews] review granted: [Bug 72281] Fix find on web pages with -webkit-user-select: none for Chromium : [Attachment 118562] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Dec 9 12:43:34 PST 2011
Ryosuke Niwa <rniwa at webkit.org> has granted Martin Kosiba
<mkosiba at chromium.org>'s request for review:
Bug 72281: Fix find on web pages with -webkit-user-select: none for Chromium
https://bugs.webkit.org/show_bug.cgi?id=72281
Attachment 118562: Patch
https://bugs.webkit.org/attachment.cgi?id=118562&action=review
------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=118562&action=review
> Source/WebKit/chromium/src/WebFrameImpl.cpp:1568
> + options.forward ? ++m_activeMatchIndexInCurrentFrame :
--m_activeMatchIndexInCurrentFrame;
We require a line per statement. Please use a regular if statement.
> Tools/DumpRenderTree/chromium/LayoutTestController.cpp:1986
> + const bool findResult = frame->find(0,
> + cppVariantToWebString(arguments[0]),
> + findOptions,
> + wrapAround,
> + 0);
Wrong style again. Please fix it before landing the patch.
More information about the webkit-reviews
mailing list