[webkit-reviews] review canceled: [Bug 73969] NodeChildList shouldn't be in NodeListNodeData : [Attachment 118546] cleanup; might have improved perf.

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has canceled Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 73969: NodeChildList shouldn't be in NodeListNodeData
https://bugs.webkit.org/show_bug.cgi?id=73969

Attachment 118546: cleanup; might have improved perf.
https://bugs.webkit.org/attachment.cgi?id=118546&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=118546&action=review


> Source/WebCore/ChangeLog:23
> +	   (WebCore::ChildNodeList::itemWithName): Added; while
DynamicNodeList's version uses TreeScope's
> +	   getElementById, this is undesirable for ChildNodeList because this
would create DynamicNodeList
> +	   on on the TreeScope and we'll end up having to walk up the entire
tree in childrenChanged.

It turned out this isn't accurate at all :( TreeScope has a DocumentOrderedMap
so it's super fast.