[webkit-reviews] review granted: [Bug 70810] nameNodeListCache should be invalidated when name attribute changes/modified. : [Attachment 118594] Updated patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Arko Saha <nghq36 at motorola.com>'s
request for review:
Bug 70810: nameNodeListCache should be invalidated when name attribute
changes/modified.
https://bugs.webkit.org/show_bug.cgi?id=70810

Attachment 118594: Updated patch
https://bugs.webkit.org/attachment.cgi?id=118594&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=118594&action=review


> LayoutTests/fast/dom/getelementsbyname-invalidation-cache.html:32
> +    shouldBeTrue("document.getElementsByName('fullname').length !=
oldLength");

You could create a function like createElement() that takes a tag name and
returned the element. That way, shouldBeTrue will include the tag name and you
don't need to add extra lines by debug.