[webkit-reviews] review granted: [Bug 74178] Add new CSS nth-children parsing tests : [Attachment 118570] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 9 09:35:24 PST 2011


Darin Adler <darin at apple.com> has granted Zoltan Herczeg
<zherczeg at webkit.org>'s request for review:
Bug 74178: Add new CSS nth-children parsing tests
https://bugs.webkit.org/show_bug.cgi?id=74178

Attachment 118570: patch
https://bugs.webkit.org/attachment.cgi?id=118570&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=118570&action=review


> Source/WebCore/css/CSSParser.cpp:8092
>      // The tokenizer checks for the construct of an+b.
>      // nth can also accept "n", "odd" or "even" but should not accept any
other token.
> -    return equalIgnoringCase(token, "odd") || equalIgnoringCase(token,
"even") || equalIgnoringCase(token, "n");
> +    return equalIgnoringCase(token, "odd") || equalIgnoringCase(token,
"even")
> +	   || equalIgnoringCase(token, "n") || equalIgnoringCase(token, "-n");

The comment now does not match the code. There is no clue here why "-n" is
something we need to allow here.


More information about the webkit-reviews mailing list