[webkit-reviews] review denied: [Bug 74100] Web Inspector: provide per Document Node count statistics : [Attachment 118574] Patch for landing

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied  review:
Bug 74100: Web Inspector: provide per Document Node count statistics
https://bugs.webkit.org/show_bug.cgi?id=74100

Attachment 118574: Patch for landing
https://bugs.webkit.org/attachment.cgi?id=118574&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=118574&action=review


> Source/WebCore/inspector/Inspector.json:55
> +		   "description": "Node name to count map."

We should not use maps as the types since as you can see you can't define
schema for it. It should be an array of objects with named properties instead.

> Source/WebCore/inspector/Inspector.json:62
> +		       { "name": "nodeCount", "$ref": "NodeCount" },

i.e. type: "array" items: { $ref: "NodeCounter" } where node counter has
properties such as tagName and a count