[webkit-reviews] review denied: [Bug 73086] Web Inspector: Add scripts navigator sidebar to scripts panel. : [Attachment 118564] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 73086: Web Inspector: Add scripts navigator sidebar to scripts panel.
https://bugs.webkit.org/show_bug.cgi?id=73086

Attachment 118564: Patch
https://bugs.webkit.org/attachment.cgi?id=118564&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=118564&action=review


> Source/WebCore/inspector/front-end/ScriptsNavigator.js:38
> +    this._panel = panel;

This dependency is not nice. You use it for a single static method and a
"select" command. It is clear that scripts panel should listen to this
navigator instead and that the static method should move here (or into the
debugger presentation model).