[webkit-reviews] review granted: [Bug 74100] Web Inspector: provide per Document Node count statistics : [Attachment 118565] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 74100: Web Inspector: provide per Document Node count statistics
https://bugs.webkit.org/show_bug.cgi?id=74100

Attachment 118565: Patch
https://bugs.webkit.org/attachment.cgi?id=118565&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=118565&action=review


> Source/WebCore/bindings/js/ScriptProfiler.h:54
> +    class DOMWrapperVisitor {

Please move this interface to the WebCore/inspector

> Source/WebCore/inspector/Inspector.json:57
> +		       { "name": "nodeCount", "type": "object" },

You should expand this into the type.

> Source/WebCore/inspector/InspectorMemoryAgent.cpp:56
> +    

blank line

> Source/WebCore/inspector/InspectorMemoryAgent.cpp:88
> +	       String name = nodeName(currentNode);

You only want names of the elements, right?