[webkit-reviews] review denied: [Bug 73616] Asynchronous path and synchronous path of SpellChecker should share the code to mark misspellings : [Attachment 118534] Patch

[bugzilla-daemon at webkit.org]

MORITA Hajime <morrita at google.com> has denied Shinya Kawanaka
<shinyak at chromium.org>'s request for review:
Bug 73616: Asynchronous path and synchronous path of SpellChecker should share
the code to mark misspellings
https://bugs.webkit.org/show_bug.cgi?id=73616

Attachment 118534: Patch
https://bugs.webkit.org/attachment.cgi?id=118534&action=review

------- Additional Comments from MORITA Hajime <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=118534&action=review


> Source/WebCore/editing/SpellChecker.cpp:175
> +    m_frame->editor()->markAndReplaceFor(m_processingRequest->mask(),
results, m_processingRequest->checkingRange(),
m_processingRequest->paragraphRange());

Could you pass SpellCheckRequest directly markAndReplaceFor() , instead of
passing independent parameters.