[webkit-reviews] review denied: [Bug 73304] Opening two popup menus by dispatchEvent() makes problems : [Attachment 118536] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 8 23:33:49 PST 2011

Kent Tamura <tkent at chromium.org> has denied Jing Zhao <jingzhao at chromium.org>'s
request for review:
Bug 73304: Opening two popup menus by dispatchEvent() makes problems

Attachment 118536: Patch

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=118536&action=review

> Source/WebCore/page/ChromeClient.h:306
> +	   virtual bool popupIsVisible() const { return false; }

Please do not add the implementation. This should be a pure virtual function.
We should implement this function for non-Chromium platforms too, and it's hard
for non-Chromium developers to find this function if this function has the
implementation here.

> Source/WebKit/chromium/src/ChromeClientImpl.h:187
> +    virtual bool popupIsVisible() const;

nit: We had better append OVERRIDE.

More information about the webkit-reviews mailing list