[webkit-reviews] review denied: [Bug 73790] [EFL] Add RefPtrEfl specialization for evas_object. : [Attachment 118316] [EFL] Add RefPtrEfl specialization for evas_object.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Dec 8 22:43:51 PST 2011
Ryosuke Niwa <rniwa at webkit.org> has denied KwangHyuk <hyuki.kim at samsung.com>'s
request for review:
Bug 73790: [EFL] Add RefPtrEfl specialization for evas_object.
https://bugs.webkit.org/show_bug.cgi?id=73790
Attachment 118316: [EFL] Add RefPtrEfl specialization for evas_object.
https://bugs.webkit.org/attachment.cgi?id=118316&action=review
------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=118316&action=review
> Source/WebCore/platform/efl/RefPtrEfl.cpp:28
> + if (LIKELY(ptr != 0))
WebKit style is not to compare with 0. So you should do LIKELY(ptr) or
LIKELY(!!ptr)
More information about the webkit-reviews
mailing list