[webkit-reviews] review granted: [Bug 73791] Upstream platform/network/blackberry/DeferredData.{h, cpp}, NetworkJob.{h, cpp} and NetworkManager.{h, cpp} : [Attachment 118515] Patch v2

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has granted Leo Yang
<leo.yang at torchmobile.com.cn>'s request for review:
Bug 73791: Upstream platform/network/blackberry/DeferredData.{h, cpp},
NetworkJob.{h, cpp} and NetworkManager.{h, cpp}
https://bugs.webkit.org/show_bug.cgi?id=73791

Attachment 118515: Patch v2
https://bugs.webkit.org/attachment.cgi?id=118515&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=118515&action=review


Assuming toASCIIHexValue usage was tested, r+.

> Source/WebCore/platform/network/blackberry/DeferredData.h:34
> +    RecursionGuard(bool &guard)

bool& . Please run check-webkit-style :)

> Source/WebCore/platform/network/blackberry/NetworkJob.h:144
> +    }

Should be moved above the private: to join the other private methods.

> Source/WebCore/platform/network/blackberry/NetworkJob.h:179
> +    bool m_needsRetryAsFTPDirectory;

Note: you can pack the bools together if you want to save some memory.