[webkit-reviews] review denied: [Bug 73798] Upstream 6 files into WebCore/platform/blackberry : [Attachment 118511] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has denied Mary Wu <mary.wu at torchmobile.com.cn>'s
request for review:
Bug 73798: Upstream 6 files into WebCore/platform/blackberry
https://bugs.webkit.org/show_bug.cgi?id=73798

Attachment 118511: Patch
https://bugs.webkit.org/attachment.cgi?id=118511&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=118511&action=review


Some nits left. Once you have fixed, I am fine with the patch, so you can ask
Leo to do the final r+ and cq.

> Source/WebCore/platform/blackberry/FileSystemBlackBerry.cpp:55
> +    fileName = filePath + cpath.length();

How about:

char *fileName = filePath + cpath.length();

> Source/WebCore/platform/blackberry/FileSystemBlackBerry.cpp:61
> +    fileNameSpace = sizeof(filePath) - (fileName - filePath) - 1;

Why not move it down to:

size_t fileNameSpace = sizeof(filePath) - (fileName - filePath) - 1;

> Source/WebCore/platform/blackberry/FileSystemBlackBerry.cpp:64
> +    dir = opendir(cpath.data());

I would suggest : DIR* dir = opendir(path.data())