[webkit-reviews] review denied: [Bug 73591] [Qt] [WK2] Webkit should release TextureMapper GL objects if page paint node is deallocated. : [Attachment 118504] Added cleaning of direct composited images

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam.rosenthal at nokia.com> has denied Viatcheslav Ostapenko
<ostapenko.viatcheslav at nokia.com>'s request for review:
Bug 73591: [Qt] [WK2] Webkit should release TextureMapper GL objects if page
paint node is deallocated.
https://bugs.webkit.org/show_bug.cgi?id=73591

Attachment 118504: Added cleaning of direct composited images
https://bugs.webkit.org/attachment.cgi?id=118504&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=118504&action=review


You're using too many names to describe the same thing.
How about:
purgeNodeTexturesRecursive
PurgeBackingStores
purgeGLResouces
recreateBackingStoreIfNeeded
purgeBackingStore
m_shouldRecreateBackingStore

> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:74
> +    // Trigger setting of correct visibility flags after everything was
allocated and initialized

Period at end of sentence.

> Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:591
> +    if (m_layerInfo.imageBackingStoreID) {
> +	  
layerTreeTileClient()->releaseImageBackingStore(m_layerInfo.imageBackingStoreID
);
> +	   m_layerInfo.imageBackingStoreID = 0;
> +    }

Early return

> Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:596
> +

Newline unnecessary

> Source/WebKit2/WebProcess/WebPage/qt/LayerTreeHostQt.cpp:440
> +    if (m_shouldRecreateTileBuffers) {

Early return.