[webkit-reviews] review denied: [Bug 73788] In prepare-ChangeLog, move top level code into prepareChangeLog() : [Attachment 118030] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 73788: In prepare-ChangeLog, move top level code into prepareChangeLog()
https://bugs.webkit.org/show_bug.cgi?id=73788

Attachment 118030: Patch
https://bugs.webkit.org/attachment.cgi?id=118030&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=118030&action=review


I think this function is way too big. We should put each block into a small
function first. As is, the patch is quite in-comprehensive and it'll mess up
the svn blame quite a lot.

> Tools/Scripts/prepare-ChangeLog:220
> +    if (%changed_line_ranges) {

You might consider putting this entire block in some function.

> Tools/Scripts/prepare-ChangeLog:233
> +	     FUNCTION: foreach my $function_range_ref (@function_ranges) {

Wrong indentation.