[webkit-reviews] review granted: [Bug 74122] Forced compositing mode breaks display of full-page PDFs in WK2 : [Attachment 118458] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Simon Fraser (smfr) <simon.fraser at apple.com>'s
request for review:
Bug 74122: Forced compositing mode breaks display of full-page PDFs in WK2
https://bugs.webkit.org/show_bug.cgi?id=74122

Attachment 118458: Patch
https://bugs.webkit.org/attachment.cgi?id=118458&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=118458&action=review


> Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp:245
> +    if (m_webPage->mainFrameHasCustomRepresentation()) {
> +	   if (m_alwaysUseCompositing && m_layerTreeHost)
> +	       exitAcceleratedCompositingMode();
> +    } else if (m_alwaysUseCompositing && !m_layerTreeHost)
> +	   enterAcceleratedCompositingMode(0);
> +}

I think this would read better with an early return if
(!m_alwaysUseCompositing). Makes it clearer that this function is only about
the forced compositing case.