[webkit-reviews] review granted: [Bug 74116] Convert some fast/regions pixel tests to reftests : [Attachment 118470] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 8 14:38:46 PST 2011


Darin Adler <darin at apple.com> has granted Jacob Goldstein <jacobg at adobe.com>'s
request for review:
Bug 74116: Convert some fast/regions pixel tests to reftests
https://bugs.webkit.org/show_bug.cgi?id=74116

Attachment 118470: Patch
https://bugs.webkit.org/attachment.cgi?id=118470&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
In the future, when changing tests to be reference tests, I would like to add
explanatory text at the top of the test. Tests that have only the test content
with no explanation are unnecessarily mysterious. With render tree results
there is an excuse to not want extraneous content cluttering up the expected
result, but with ref tests we can just repeat the explanation in both the test
and the expected results.


More information about the webkit-reviews mailing list