[webkit-reviews] review denied: [Bug 74123] Move MediaDocument styles into CSS. Set black background for chromium. : [Attachment 118461] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Dale Curtis
<dalecurtis at chromium.org>'s request for review:
Bug 74123: Move MediaDocument styles into CSS. Set black background for
chromium.
https://bugs.webkit.org/show_bug.cgi?id=74123

Attachment 118461: Patch
https://bugs.webkit.org/attachment.cgi?id=118461&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=118461&action=review


>> Source/WebCore/html/MediaDocument.cpp:97
>> +	document()->recalcStyle(Node::Force);
> 
> So, as I was saying earlier, this should not be necessary.  I don't have a
build in front of me, but perhaps you could take a peek and see if the style is
_ever_ resolved on this document. And if it is, when. It seems weird that we
have to kludge this like so.

Yes, that is absolutely unnecessary and if adding it has any benefit then there
is a bug elsewhere.