[webkit-reviews] review granted: [Bug 73099] Web Inspector: Unsafe cross origin access errors should show stack trace in console. : [Attachment 118463] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 73099: Web Inspector: Unsafe cross origin access errors should show stack
trace in console.
https://bugs.webkit.org/show_bug.cgi?id=73099

Attachment 118463: Patch
https://bugs.webkit.org/attachment.cgi?id=118463&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=118463&action=review


> Source/WebCore/page/DOMWindow.cpp:909
> +	   stackTrace =
createScriptCallStack(ScriptCallStack::maxCallStackSizeToCapture, true);

Should we use createScriptCallStackForInspector here?

> Source/WebCore/page/DOMWindow.cpp:928
> +	       console()->addMessage(JSMessageSource, LogMessageType,
ErrorMessageLevel, message, 0, String(), timer->stackTrace());

Please file a bug requesting to introduce addMessage that would only accept
message and stack (with no line number and url). I guess you are not doing it
here in order not to update expectations, right?

> Source/WebCore/page/DOMWindow.cpp:1779
> +    RefPtr<ScriptCallStack> stackTrace =
createScriptCallStack(ScriptCallStack::maxCallStackSizeToCapture, true);

Should we use createScriptCallStackForInspector here?