[webkit-reviews] review granted: [Bug 73994] [Qt][WK2] Fix tst_QQuickWebView::scrollRequest() API test : [Attachment 118401] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 8 14:10:32 PST 2011


Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Michael Brüning
<michael.bruning at nokia.com>'s request for review:
Bug 73994: [Qt][WK2] Fix tst_QQuickWebView::scrollRequest() API test
https://bugs.webkit.org/show_bug.cgi?id=73994

Attachment 118401: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=118401&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=118401&action=review


r+ as this is an improvement, but this could be even better

> Source/WebKit2/UIProcess/API/qt/tests/html/scroll.html:26
> +This is a test page This is a test page This is a test page This is a test
page This is a test page This is a test page This is a test page This is a test
page This is a test page This is a test page This is a test page This is a test
page This is a test page This is a test page This is a test page This is a test
page This is a test page This is a test page This is a test page This is a test
page This is a test page This is a test page This is a test page This is a test
page This is a test page This is a test page This is a test page This is a test
page This is a test page This is a test page This is a test page This is a test
page This is a test page This is a test page This is a test page This is a test
page This is a test page This is a test page This is a test page This is a test
page This is a test page This is a test page This is a test page This is a test
page This is a test page This is a test page This is a test page This is a test
page This is a test page This is a test page This is a test page This is a test
page This is a test page This is a test page This is a test page This is a test
page This is a test page This is a test page This is a test page This is a test
page This is a test page This is a test page This is a test page This is a test
page This is a test page This is a test page This is a test page This is a test
page This is a test page This is a test page This is a test page This is a test
page This is a test page This is a test page This is a test page This is a test
page This is a test page This is a test page This is a test page This is a test
page This is a test page This is a test page This is a test page This is a test
page This is a test page This is a test page This is a test page This is a test
page This is a test page This is a test page This is a test page This is a test
page This is a test page This is a test page This is a test page This is a test
page This is a test page This is a test page This is a test page This is a test
page This is a test page This is a test page This is a test page This is a test
page This is a test page This is a test page This is a test page This is a test
page This is a test page This is a test page This is a test page This is a test
page This is a test page This is a test page This is a test page This is a test
page This is a test page This is a test page This is a test page This is a test
page This is a test page This is a test page This is a test page This is a test
page This is a test page This is a test page This is a test page This is a test
page This is a test page This is a test page This is a test page This is a test
page This is a test page This is a test page This is a test page This is a test
page This is a test page This is a test page This is a test page This is a test
page This is a test page This is a test page This is a test page This is a test
page This is a test page This is a test page This is a test page This is a test
page This is a test page This is a test page This is a test page This is a test
page This is a test page This is a test page This is a test page This is a test
page This is a test page This is a test page This is a test page This is a test
page This is a test page This is a test page This is a test page This is a test
page This is a test page This is a test page This is a test page This is a test
page This is a test page This is a test page This is a test page This is a test
page This is a test page This is a test page This is a test page This is a test
page This is a test page This is a test page This is a test page This is a test
page This is a test page This is a test page This is a test page This is a test
page This is a test page This is a test page This is a test page This is a test
page This is a test page This is a test page This is a test page This is a test
page This is a test page This is a test page This is a test page This is a test
page This is a test page This is a test page This is a test page This is a test
page This is a test page This is a test page This is a test page This is a test
page This is a test page This is a test page This is a test page This is a test
page This is a test page This is a test page This is a test page This is a test
page This is a test page This is a test page This is a test page This is a test
page This is a test page This is a test page This is a test page This is a test
page This is a test page This is a test page This is a test page This is a test
page This is a test page This is a test page This is a test page This is a test
page This is a test page This is a test page This is a test page This is a test
page This is a test page This is a test page This is a test page This is a test
page This is a test page This is a test page This is a test page This is a test
page This is a test page This is a test page This is a test page This is a test
page This is a test page This is a test page This is a test page 

There are other ways to make the page long.... for instance a div with height
set. (color as well would be preferred)

> Source/WebKit2/UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:263

> +    QTest::qWait(200);

?This seems more like a workaround. Why is there no comment why this is needed,
as it is not obvious?

> Source/WebKit2/UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:273

> +    int y = -qRound(50 * webView()->page()->scale());
>      QVERIFY(webView()->page()->pos().y() == y);
>  }

Please add a reload of the page here and verify again that it is at the right
place. Can be another patch.


More information about the webkit-reviews mailing list