[webkit-reviews] review granted: [Bug 74061] WebProcess and PluginProcess should inherit environment variables provided in LC_DYLD_ENVIRONMENT of main executable binary : [Attachment 118342] Patch v1

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Mark Rowe (bdash) <mrowe at apple.com>'s
request for review:
Bug 74061: WebProcess and PluginProcess should inherit environment variables
provided in LC_DYLD_ENVIRONMENT of main executable binary
https://bugs.webkit.org/show_bug.cgi?id=74061

Attachment 118342: Patch v1
https://bugs.webkit.org/attachment.cgi?id=118342&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=118342&action=review


Please fix the *s, otherwise, r=me.

> Source/WebKit2/UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.h:45
> +    DynamicLinkerEnvironmentExtractor(NSString* executablePath, cpu_type_t
architecture);

Please move * to the other side.

> Source/WebKit2/UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.h:53
> +    void processSingleArchitecture(const void *fileData, size_t fileSize);
> +    void processFatFile(const void *fileData, size_t fileSize);
> +    void processLoadCommands(const void *fileData, int32_t numberOfCommands,
bool shouldByteSwap);
> +    size_t processLoadCommand(const load_command *rawLoadCommand, bool
shouldByteSwap);

Please move * to the other-other side.

>
Source/WebKit2/UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.mm:133
> +    for (HashMap<String, String>::const_iterator it =
m_extractedVariables.begin(); it != m_extractedVariables.end(); ++it) {

We usually pull the end iterator out of the loop so it is not recomputed.