[webkit-reviews] review granted: [Bug 74102] Use bitfield for bool data members in BitmapImage. : [Attachment 118447] Take 3, fix Qt build breakage.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 8 13:14:58 PST 2011


Darin Adler <darin at apple.com> has granted Yongjun Zhang
<yongjun_zhang at apple.com>'s request for review:
Bug 74102: Use bitfield for bool data members in BitmapImage.
https://bugs.webkit.org/show_bug.cgi?id=74102

Attachment 118447: Take 3, fix Qt build breakage.
https://bugs.webkit.org/attachment.cgi?id=118447&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=118447&action=review


> Source/WebCore/platform/graphics/BitmapImage.h:92
> +    bool m_haveMetadata:1;
> +    bool m_isComplete:1;
> +    bool m_hasAlpha:1;

Our normal style is to put spaces around the colons.


More information about the webkit-reviews mailing list