[webkit-reviews] review denied: [Bug 73826] [Qt] request parameter of QQuickWebView::navigationRequested is not a registered type : [Attachment 117941] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Jesus Sanchez-Palencia
<jesus at webkit.org>'s request for review:
Bug 73826: [Qt] request parameter of QQuickWebView::navigationRequested is not
a registered type
https://bugs.webkit.org/show_bug.cgi?id=73826

Attachment 117941: Patch
https://bugs.webkit.org/attachment.cgi?id=117941&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=117941&action=review


r- because of the leak. Looks good otherwise.

> Source/WebKit2/UIProcess/API/qt/qwebnavigationrequest.cpp:48
> +    , d(new QWebNavigationRequestPrivate(url, button, modifiers))

Ooops, the d-pointer is leaked :)