[webkit-reviews] review granted: [Bug 74104] Web Inspector: return node counts on the document / detached root basis : [Attachment 118419] [PATCH] Proposed patch.

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 74104: Web Inspector: return node counts on the document / detached root
basis
https://bugs.webkit.org/show_bug.cgi?id=74104

Attachment 118419: [PATCH] Proposed patch.
https://bugs.webkit.org/attachment.cgi?id=118419&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=118419&action=review


This changed should be accompanied with a test.

> Source/WebCore/bindings/v8/ScriptProfiler.cpp:220
> +    CounterVisitor counterVisitor(domAgent, result.get());

This visitor will traverse all nodes no matter which page they belong too. We
should collect only nodes relevant to a particular page which user is
inspecting. You can filter them by node->document()->frame()->page() for
attached documents and report all nodes from alive detached documents.