[webkit-reviews] review granted: [Bug 74095] Cache visited link hash : [Attachment 118398] patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 74095: Cache visited link hash
https://bugs.webkit.org/show_bug.cgi?id=74095

Attachment 118398: patch
https://bugs.webkit.org/attachment.cgi?id=118398&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=118398&action=review


r=me assuming you fix the fastGetAttribute thing Andreas pointed out

> Source/WebCore/ChangeLog:15
> +	   Note that technically we would need to invalidate these hashes also
on dynamic document base URL change
> +	   but that scenario seems to be unsupported by many other parts of the
WebKit too.

Is there some way we could avoid digging ourselves deeper on this one? Perhaps
a base URL change is unusual enough that we could afford to iterate the
document when it happens?

> Source/WebCore/css/SelectorChecker.cpp:1321
> +	   else if (const AtomicString* attr = linkAttribute(node))
> +	       hash = visitedLinkHash(m_document->baseURL(), *attr);

Since we’re touching this code I would have spelled out the word attribute.