[webkit-reviews] review denied: [Bug 74074] [Qt] Visualize mock points in the Qt MiniBrowser : [Attachment 118393] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Dec 8 09:11:12 PST 2011
Tor Arne Vestbø <vestbo at webkit.org> has denied Alexander Færøy <ahf at 0x90.dk>'s
request for review:
Bug 74074: [Qt] Visualize mock points in the Qt MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=74074
Attachment 118393: Patch
https://bugs.webkit.org/attachment.cgi?id=118393&action=review
------- Additional Comments from Tor Arne Vestbø <vestbo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=118393&action=review
> Tools/MiniBrowser/qt/BrowserWindow.cpp:92
> + bool pressed = touchPoint.state != Qt::TouchPointReleased;
> + QPointF position = touchPoint.area.topLeft();
> + position.rx() -= geometry().x();
> + position.ry() -= geometry().y();
Move this down to where you set it, and remove the pressed-variable, you can
set the property directly based on touchPoint.state != Qt::TouchPointReleased
More information about the webkit-reviews
mailing list