[webkit-reviews] review denied: [Bug 73791] Upstream platform/network/blackberry/DeferredData.{h, cpp}, NetworkJob.{h, cpp} and NetworkManager.{h, cpp} : [Attachment 117823] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has denied Leo Yang
<leo.yang at torchmobile.com.cn>'s request for review:
Bug 73791: Upstream platform/network/blackberry/DeferredData.{h, cpp},
NetworkJob.{h, cpp} and NetworkManager.{h, cpp}
https://bugs.webkit.org/show_bug.cgi?id=73791

Attachment 117823: Patch
https://bugs.webkit.org/attachment.cgi?id=117823&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=117823&action=review


Still some stuff to fix.

> Source/WebCore/platform/network/blackberry/DeferredData.cpp:40
> +void DeferredData::deferOpen(int status, const WTF::String& message)

Do we need the WTF:: prefix?

> Source/WebCore/platform/network/blackberry/NetworkJob.cpp:69
> +}

I wonder if we can use toASCIIHexValue from wtf/ASCIICType.h?

> Source/WebCore/platform/network/blackberry/NetworkManager.cpp:117
> +#if OS(QNX)

Can be removed