[webkit-reviews] review denied: [Bug 73534] upstream BlackBerry porting of MIMETypeRegistry/KeyboardEvent : [Attachment 118348] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 8 07:15:27 PST 2011

Rob Buis <rwlbuis at gmail.com> has denied Mary Wu <mary.wu at torchmobile.com.cn>'s
request for review:
Bug 73534: upstream BlackBerry porting of MIMETypeRegistry/KeyboardEvent

Attachment 118348: Patch

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=118348&action=review

Almost done, but since this needs cq+ the nit needs to be fixed first.

> Source/WebCore/platform/blackberry/PlatformKeyboardEventBlackBerry.cpp:482
> +void PlatformKeyboardEvent::getCurrentModifierState(bool& shiftKey, bool&
ctrlKey, bool& altKey, bool& metaKey)

The parameter names can be best removed or marked as unused.

More information about the webkit-reviews mailing list