[webkit-reviews] review denied: [Bug 74083] Define DEBUG_GL_COMMANDS only in debug builds. : [Attachment 118380] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 8 06:49:44 PST 2011


Noam Rosenthal <noam.rosenthal at nokia.com> has denied Nayan Kumar K
<nayankk at motorola.com>'s request for review:
Bug 74083: Define DEBUG_GL_COMMANDS only in debug builds.
https://bugs.webkit.org/show_bug.cgi?id=74083

Attachment 118380: Patch
https://bugs.webkit.org/attachment.cgi?id=118380&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=118380&action=review


> Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp:104
> -#define GL_CMD(x) {x, debugGLCommand(#x, __LINE__); }
> +#define GL_CMD(x) {x, debugGLCommand(#x, __LINE__) }

How would this work?
Please test this fix on debug builds as well :)


More information about the webkit-reviews mailing list