[webkit-reviews] review granted: [Bug 71695] Regression(r53595): Sync xhr requests in workers aren't terminated on worker close. : [Attachment 118282] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 8 00:15:09 PST 2011


Zoltan Herczeg <zherczeg at webkit.org> has granted David Levin
<levin at chromium.org>'s request for review:
Bug 71695: Regression(r53595): Sync xhr requests in workers aren't terminated
on worker close.
https://bugs.webkit.org/show_bug.cgi?id=71695

Attachment 118282: Patch
https://bugs.webkit.org/attachment.cgi?id=118282&action=review

------- Additional Comments from Zoltan Herczeg <zherczeg at webkit.org>
r=me.

Looks like we were not fast enough. You should add more text to the changelog
to describe the issue and why your change fix it.

I still think DRT should check if there is a hanging worker and throw some
error message. But that coudl go into a differnt patch (I hope Nandi is up for
the task).


More information about the webkit-reviews mailing list