[webkit-reviews] review denied: [Bug 73798] Upstream 6 files into WebCore/platform/blackberry : [Attachment 118309] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Dec 7 19:12:57 PST 2011
Rob Buis <rwlbuis at gmail.com> has denied Mary Wu <mary.wu at torchmobile.com.cn>'s
request for review:
Bug 73798: Upstream 6 files into WebCore/platform/blackberry
https://bugs.webkit.org/show_bug.cgi?id=73798
Attachment 118309: Patch
https://bugs.webkit.org/attachment.cgi?id=118309&action=review
------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=118309&action=review
Looking good, but still some issues left.
> Source/WebCore/platform/blackberry/FileSystemBlackBerry.cpp:54
> + // loop invariant: directory part + '/'
Should be made a sentence.
> Source/WebCore/platform/blackberry/PlatformTouchEventBlackBerry.cpp:38
> +#if PLATFORM(BLACKBERRY)
This one should also not be needed, this is a BlackBerry file.
> Source/WebCore/platform/blackberry/SharedTimerBlackBerry.cpp:29
> + friend void setSharedTimerFiredFunction(void (*f)());
Is this friend declaration needed?
> Source/WebCore/platform/blackberry/SharedTimerBlackBerry.cpp:37
> + bool m_started;
Could this be moved to private part?
More information about the webkit-reviews
mailing list