[webkit-reviews] review granted: [Bug 73388] Upstream the BlackBerry porting of network Resource : [Attachment 118306] Patch v4

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has granted Leo Yang
<leo.yang at torchmobile.com.cn>'s request for review:
Bug 73388: Upstream the BlackBerry porting of network Resource
https://bugs.webkit.org/show_bug.cgi?id=73388

Attachment 118306: Patch v4
https://bugs.webkit.org/attachment.cgi?id=118306&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=118306&action=review


Some nits, but you cant fix them before landing. r+

> Source/WebCore/platform/network/blackberry/ResourceHandleBlackBerry.cpp:46
> +    virtual void didReceiveData(ResourceHandle*, const char*, int, int
lengthReceived);

Didn't see this before, but lengthReceived is not needed.

> Source/WebCore/platform/network/blackberry/ResourceHandleBlackBerry.cpp:172
> +    static const double s_syncLoadTimeOut = 60.0; // seconds

60.0 -> 60.
Also s_syncLoadTimeOut is a bit weird. It looks like a global constant but is
just used in this function. Should it use DEFINE_STATIC_LOCAL? Maybe look at
similar code like this in WebCore/, but no blocker.