[webkit-reviews] review denied: [Bug 73388] Upstream the BlackBerry porting of network Resource : [Attachment 118302] Patch v3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 7 18:35:23 PST 2011


Rob Buis <rwlbuis at gmail.com> has denied Leo Yang
<leo.yang at torchmobile.com.cn>'s request for review:
Bug 73388: Upstream the BlackBerry porting of network Resource
https://bugs.webkit.org/show_bug.cgi?id=73388

Attachment 118302: Patch v3
https://bugs.webkit.org/attachment.cgi?id=118302&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=118302&action=review


Some nits.... Mainly empty space related.

> Source/WebCore/platform/network/blackberry/ResourceError.h:28
> +

Why empty line?

> Source/WebCore/platform/network/blackberry/ResourceHandleBlackBerry.cpp:190
> +WTF::PassRefPtr<SharedBuffer> ResourceHandle::bufferedData()

Is WTF needed?

> Source/WebCore/platform/network/blackberry/ResourceRequest.h:113
> +

Why empty line?

> Source/WebCore/platform/network/blackberry/ResourceResponse.h:47
> +    bool isMultipartPayload() const { return m_isMultipartPayload; }

Why not an empty line here?

> Source/WebCore/platform/network/blackberry/ResourceResponse.h:51
> +

Why empty line?


More information about the webkit-reviews mailing list