[webkit-reviews] review granted: [Bug 73911] <li value="0"> behaves like <li> (the same for negative numbers) : [Attachment 118228] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 7 10:55:32 PST 2011

Darin Adler <darin at apple.com> has granted Florin Malita <fmalita at google.com>'s
request for review:
Bug 73911: <li value="0"> behaves like <li> (the same for negative numbers)

Attachment 118228: Patch

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=118228&action=review

> Source/WebCore/html/HTMLLIElement.h:43
> +    void setValue(const AtomicString&);

This is great refactoring. I don’t think the name of the function is good,
though, because it doesn’t set the value on the element. Maybe
setValueInRenderer or parseValue.

More information about the webkit-reviews mailing list