[webkit-reviews] review denied: [Bug 72178] Fix mixed content handling for AssociatedURLLoader. : [Attachment 118222] Partial revert to restore old behavior for workers.

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Aaron Colwell
<acolwell at chromium.org>'s request for review:
Bug 72178: Fix mixed content handling for AssociatedURLLoader.
https://bugs.webkit.org/show_bug.cgi?id=72178

Attachment 118222: Partial revert to restore old behavior for workers.
https://bugs.webkit.org/attachment.cgi?id=118222&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=118222&action=review


> Source/WebCore/ChangeLog:11
> +	   No new tests. (OOPS!)

Can we not test this problem here?

> Source/WebCore/loader/cache/CachedResource.cpp:139
>      case ResourceRequest::TargetIsScript:
> -	   return CachedResource::Script;
> +	   // TODO: Change back to CachedResource::Script once
http://crbug.com/106383 has been fixed.
> +	   return CachedResource::RawResource;

TODO -> FIXME

This patch looks wrong on it's face.  I'd rather revert the original patch
entirely than land this "obviously wrong" code.  Can we not just fix the bug
directly?