[webkit-reviews] review granted: [Bug 73911] <li value="0"> behaves like <li> (the same for negative numbers) : [Attachment 118217] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Florin Malita <fmalita at google.com>'s
request for review:
Bug 73911: <li value="0"> behaves like <li> (the same for negative numbers)
https://bugs.webkit.org/show_bug.cgi?id=73911

Attachment 118217: Patch
https://bugs.webkit.org/attachment.cgi?id=118217&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Patch seems OK. Three thoughts:

1) This logic should not be repeated twice. We should find a way to share the
code between these two call sites.
2) There is no need for a special case for the null string in
HTMLLIElement::attach.
3) Normally I would spell it "OK", not "Ok".