[webkit-reviews] review denied: [Bug 73616] Asynchronous path and synchronous path of SpellChecker should share the code to mark misspellings : [Attachment 118196] Patch

[bugzilla-daemon at webkit.org]

MORITA Hajime <morrita at google.com> has denied Shinya Kawanaka
<shinyak at google.com>'s request for review:
Bug 73616: Asynchronous path and synchronous path of SpellChecker should share
the code to mark misspellings
https://bugs.webkit.org/show_bug.cgi?id=73616

Attachment 118196: Patch
https://bugs.webkit.org/attachment.cgi?id=118196&action=review

------- Additional Comments from MORITA Hajime <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=118196&action=review


Could you split the patch into some trivial part (like renaming, exporting an
internal class, etc.) and possibly-observable change like make marking code
shared?

> Source/WebCore/ChangeLog:6
> +	   Need a short description and bug URL (OOPS!)

You don't need this.

> Source/WebCore/editing/SpellChecker.h:80
> +    class InternalSpellCheckRequest;

This doesn't need to be a nested class.