[webkit-reviews] review granted: [Bug 73961] The code to create a NodeListsNodeData is duplicated everywhere : [Attachment 118143] Fixed some bug

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 73961: The code to create a NodeListsNodeData is duplicated everywhere
https://bugs.webkit.org/show_bug.cgi?id=73961

Attachment 118143: Fixed some bug
https://bugs.webkit.org/attachment.cgi?id=118143&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=118143&action=review


> Source/WebCore/dom/NodeRareData.h:135
> +	       setNodeLists(NodeListsNodeData::create());
> +	       if (TreeScope* treeScope = node->treeScope())
> +		   treeScope->addNodeListCache();

Do we really want this inlined? I would have put this part into a non-inline
helper function.

Also, this function is kind of long. Maybe we could put it outside the class
definition.